Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two compiler warnings, which may indicate bugs:
Fixes warning:
Rather than perform a pointer cast, just explicitly load two bytes and shift them to make a 16-bit word. This has the additional advantage of being more portable, because we can specify the endian-ness with which we read the data. ( I used a little-endian order for backward compatibility with x86 machines. It's not clear to me whether the GDSII format specifies a particular interpretation of bitfield indices, so that endianness matters here?)
Also fix warning:
The
std::string + char
method does not apply to string literals, which are just pointers. Instead, I just leave a placeholder character X in the string and overwrite it withDType
.